fix: convert byteOffset and byteLength to getters#215
Conversation
rvagg
left a comment
rvagg
left a comment
There was a problem hiding this comment.
sgtm but I'll leave it to @Gozala to weigh in; I'm a bit tired to having to deal with these myself, I think the intention was to have an ArrayBuffer that could also be a CID itself (kind of like the Cid type in Go which is just a wrapped byte string) but we've not really evolved beyond just having a concrete class—does the new interface (and/or the newly proposed ones) get us any closer? is it worth the bother holding on to these as important properties?
|
@rvagg this was @Gozala's suggestion 😜
Most of them remove these fields so no, not exactly.
I don't think so, no. Can restore #210 if that's a better solution. |
|
@Gozala Happy for this go in to unblock the roll out of multiformats v10 to @ipld/dag-*, ipfs, etc? |
RangerMauve
left a comment
RangerMauve
left a comment
There was a problem hiding this comment.
LGTM, might as well wait for gozala tho
|
Ah sorry @achingbrain I have concurrently submitted #216. I'm happy with either, that said mine takes care of coverage issues reported in this pr through this change 16d6ef7 |
|
🎉 This PR is included in version 10.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
5 participants
Fixes #208 by converting
.byteOffsetand.byteLengthproperties to getters.Supersedes #210